Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sidebar responsiveness #1376

Merged
merged 16 commits into from
Apr 11, 2023
Merged

feat: add sidebar responsiveness #1376

merged 16 commits into from
Apr 11, 2023

Conversation

juniorboos
Copy link
Contributor

Relates to:

Screenshots (if visual changes)

Old New
image image image

Proposed Changes

  • Move the sidebar to the top on smaller devices and make it full screen when not collapsed.

@juniorboos juniorboos self-assigned this Apr 10, 2023
@juniorboos juniorboos marked this pull request as ready for review April 10, 2023 15:01
@nunocaseiro nunocaseiro added enhancement New feature or request frontend labels Apr 10, 2023
@nunocaseiro nunocaseiro requested a review from a team April 10, 2023 15:02
@nunocaseiro nunocaseiro added this to the Full Version milestone Apr 10, 2023
StereoPT
StereoPT reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible can you also reflect these changes in our Storybook?

frontend/src/components/Sidebar/Content/Content.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/Content/Content.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/Header/Header.tsx Outdated Show resolved Hide resolved
@juniorboos
Copy link
Contributor Author

If possible can you also reflect these changes in our Storybook?

Can you explain what you meant by this? I've added the collapsible logic to the stories, and it can be seen using the "Change viewport" option in the toolbar. Should I add anything else?
image

@juniorboos juniorboos requested a review from StereoPT April 11, 2023 10:09
@juniorboos juniorboos merged commit f7d70df into main Apr 11, 2023
@juniorboos juniorboos deleted the feat/add-sidebar-responsiveness branch April 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@StereoPT StereoPT Awaiting requested review from StereoPT

Assignees

@juniorboos juniorboos

Labels
enhancement New feature or request frontend
Projects
SPLIT • Frontend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
3 participants
@juniorboos @StereoPT @nunocaseiro