Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Tiles responsiveness #1388

Merged
merged 8 commits into from
Apr 14, 2023
Merged

feat: add Tiles responsiveness #1388

merged 8 commits into from
Apr 14, 2023

Conversation

juniorboos
Copy link
Contributor

@juniorboos juniorboos commented Apr 13, 2023 •
edited
Loading

Relates to:

Screenshots (if visual changes)

Old New
image image
image image
image image

Proposed Changes

  • Move Tile styles to a variant instead of a const.
  • Fix text underneath TileBlob with relative position.
  • Move padding to StyledTile so it can be used by the TileArrow as well.
  • Hide overflow so that the TileBlob svg fits inside the container.
  • Replace unnecessary absolute TileArrow positioning with alignSelf.
  • Add textShadow so that the text can be visible when above TileBlob.
  • Replace grid display with flex for Tiles to be responsive according to the container's width.

@juniorboos juniorboos marked this pull request as ready for review April 13, 2023 12:45
@juniorboos juniorboos requested a review from nunocaseiro April 13, 2023 12:45
@juniorboos juniorboos self-assigned this Apr 13, 2023
@juniorboos juniorboos added frontend enhancement New feature or request labels Apr 13, 2023
@juniorboos juniorboos requested a review from a team April 13, 2023 12:46
nunocaseiro

This comment was marked as outdated.

Sign in to view

@juniorboos juniorboos requested a review from nunocaseiro April 14, 2023 10:03
StereoPT
StereoPT approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗝️

@juniorboos juniorboos merged commit 87c7dfe into main Apr 14, 2023
@juniorboos juniorboos deleted the feat/add-tile-responsiveness branch April 14, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

@tutods tutods tutods approved these changes

@StereoPT StereoPT StereoPT approved these changes

@rpvsilva rpvsilva Awaiting requested review from rpvsilva

@dsousa12 dsousa12 Awaiting requested review from dsousa12

@RubenMCCarreira RubenMCCarreira Awaiting requested review from RubenMCCarreira

Assignees

@juniorboos juniorboos

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juniorboos @StereoPT @tutods @nunocaseiro