Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress Fix #2468

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Cypress Fix #2468

merged 2 commits into from
Apr 2, 2024

Conversation

ifarzana
Copy link
Contributor

@ifarzana ifarzana commented Apr 2, 2024

  • Fix for cypress errors when deleting the widget on layout editor

@ifarzana ifarzana requested a review from maurofmferrao April 2, 2024 15:16
@ifarzana
Copy link
Contributor Author

ifarzana commented Apr 2, 2024

TEST: /Layout/Editor/layout_editor_clock.cy.js, /Layout/Editor/layout_editor_dataset.cy.js, /Layout/Editor/layout_editor_rss_ticker.cy.js END

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8525284255

maurofmferrao
maurofmferrao approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ifarzana
Copy link
Contributor Author

ifarzana commented Apr 2, 2024

TEST: /Layout/Editor/layout_editor_clock.cy.js, /Layout/Editor/layout_editor_dataset.cy.js, /Layout/Editor/layout_editor_rss_ticker.cy.js END

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Test Suite: failed ❌
https://github.com/xibosignage/xibo-cms/actions/runs/8525709836

@ifarzana ifarzana merged commit 6677ef6 into giacobini Apr 2, 2024
1 of 3 checks passed
@ifarzana ifarzana deleted the feature/cypress_tests_delete_widget branch April 2, 2024 15:57
@ifarzana ifarzana self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurofmferrao maurofmferrao maurofmferrao approved these changes

Assignees

@ifarzana ifarzana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifarzana @maurofmferrao