Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Widget naming for elements #2481

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Confusing Widget naming for elements #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ui/src/editor-core/properties-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,18 @@ PropertiesPanel.prototype.render = function(
}
};

// If it's an element of type global
// hide widget name input
if (
(isElement || isElementGroup) &&
targetAux.elementType === 'global'
) {
self.DOMObject.find('#advancedTab input[name="name"]')
.each(function(_dx, el) {
$(el).parent().hide();
});
}

if (isElementGroup) {
const groupProperties = [];
// if it's an element group and we have a slot
Expand Down
2 changes: 1 addition & 1 deletion views/common.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@
bringRegionToView: "{{ "Bring selected %regionType% back to the Layout view." |trans }}",
},
widget: {
name: "{{ "Widget Name" |trans }}",
name: "{{ "Configuration Name" |trans }}",
nameHelpText: "{{ "An optional name for this widget" |trans }}",
useDuration: "{{ "Set a duration?" |trans }}",
useDurationHelpText: "{{ "Select to provide a specific duration for this Widget" |trans }}",
Expand Down