-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev irnl correction #10
Open
JoschD
wants to merge
30
commits into
xsuite:main
Choose a base branch
from
JoschD:dev_irnl_correction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to correct the nonlinear errors in the IR via https://github.com/pylhc/irnl_rdt_correction instead of the fortran module. This is deactivated by default, but can be enabled via config.
There is a new example
hllhc14_collision_python_irnl
that uses the new correction.Unresolved Problems:
I added an optional pre-tuning before calculating the corrections, which corrects the orbit and tries to optimize the tune. I thought this would increase the accuracy of the correction, e.g. better beta-functions and better orbit for the calculation of the correction values, but instead, when this is activated, the tunes cannot be matched properly for the lhcb2 line after correction. This is very weird, as the correction values themselves do not look that different. By default this "pre-tuning" is therefore now deactivated.
I am not sure why the correction in IR2 and IR8 is deactivated.
xmask in general (probably unrelated to the PR)
hllhc15_collision
to work at all, as theacc-models-lhc
path given in the config is outside of the repository003_lumi_level.py
to run in eitherhllhc14_collision_python_irnl
orhllhc14_collision
as it fails with"ValueError: On entry to DLASCL parameter number 4 had an illegal value"
in the matching of the leveling.Checklist
Mandatory:
Optional: