-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration options to PostgreSQL #598
Conversation
a02104e
to
46e398c
Compare
@mchoma can you have a look? |
f8ab5ab
to
46077ef
Compare
a8b710d
to
5c625c1
Compare
Thanks, I have provided second round of review. Of course at the end we will need som CI run to show everything is allright. I assume you will add to description - once editing description please update it as it is out of date. |
5c625c1
to
fa3eabc
Compare
fa3eabc
to
a2cb963
Compare
@mchoma Tnks again for your review! I hope I fixed everything you pointed out |
@mchoma I updated the description; about CI runs, all runs done for the other two related MRs for our CI, have been done using this changes: do you want them linked here too? |
As neither Miroslav not Martin are not around this year anymore, I dare to merge it. Thanks. |
This PR:
PostgreSQL
builder for the postgres image which allows to differentiate images arguments and environment variablesRedHatPostgreSQL
andOfficialPostgreSQL
to handle respectively red hat Postgres image and the official Postgres imagePostgreSQL
->AbstractSQLDatabase
->AbstractDatabase
to propagate images arguments and environment variables and preserve default valuesPlease make sure your PR meets the following requirements: