Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options to PostgreSQL #598

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tommaso-borgato
Copy link
Contributor

@tommaso-borgato tommaso-borgato commented Nov 5, 2024

This PR:

  • deprecates PostgreSQL builder for the postgres image which allows to differentiate images arguments and environment variables
    • adds RedHatPostgreSQL and OfficialPostgreSQL to handle respectively red hat Postgres image and the official Postgres image
  • makes the necessary adaptations along the class hierarchy PostgreSQL -> AbstractSQLDatabase -> AbstractDatabase to propagate images arguments and environment variables and preserve default values

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@tommaso-borgato tommaso-borgato force-pushed the issues-597 branch 5 times, most recently from a02104e to 46e398c Compare November 7, 2024 14:00
@tommaso-borgato tommaso-borgato marked this pull request as ready for review November 12, 2024 08:16
@tommaso-borgato
Copy link
Contributor Author

@mchoma can you have a look?

@tommaso-borgato tommaso-borgato force-pushed the issues-597 branch 4 times, most recently from a8b710d to 5c625c1 Compare December 4, 2024 16:52
@tommaso-borgato
Copy link
Contributor Author

@mchoma @simkam Thank you for your review! I hope I've fixed everything you pointed out...

@mchoma
Copy link
Contributor

mchoma commented Dec 5, 2024

@mchoma @simkam Thank you for your review! I hope I've fixed everything you pointed out...

Thanks, I have provided second round of review. Of course at the end we will need som CI run to show everything is allright. I assume you will add to description - once editing description please update it as it is out of date.

@tommaso-borgato
Copy link
Contributor Author

@mchoma Tnks again for your review! I hope I fixed everything you pointed out

@mchoma mchoma self-assigned this Dec 6, 2024
@tommaso-borgato
Copy link
Contributor Author

tommaso-borgato commented Dec 9, 2024

@mchoma I updated the description; about CI runs, all runs done for the other two related MRs for our CI, have been done using this changes: do you want them linked here too?

@mchoma
Copy link
Contributor

mchoma commented Dec 9, 2024

As neither Miroslav not Martin are not around this year anymore, I dare to merge it. Thanks.

@mchoma mchoma merged commit c18698a into xtf-cz:master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants