Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix line shape handling #168

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix line shape handling #168

merged 1 commit into from
Nov 16, 2023

Conversation

drexhage
Copy link
Contributor

@drexhage drexhage commented Nov 12, 2023

Description

I wanted to use the command line svg2tikz using this svg https://vega.github.io/editor/#/examples/vega-lite/stacked_bar_h (click on export as svg)

But when I ran the command it errored out as

...
    pathcode, options = self._handle_shape(node)
ValueError: too many values to unpack (expected 2)

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Has been tested with the same svg

Checklist:

  • My code follows the style guidelines of this project (black/pylint)
  • I have updated the changelog with the corresponding changes
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ldevillez
Copy link
Collaborator

Hello @drexhage

Thanks for the contribution 👍

1 similar comment
@ldevillez
Copy link
Collaborator

Hello @drexhage

Thanks for the contribution 👍

@ldevillez ldevillez merged commit 823c59b into xyz2tex:master Nov 16, 2023
4 checks passed
@ldevillez ldevillez mentioned this pull request Nov 16, 2023
@drexhage drexhage mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants