Fix segfault on empty password (#542)

yandex · Nov 13, 2023 · e2e3ee6 · e2e3ee6
1 parent 9a42394
commit e2e3ee6
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/sources/auth_query.c b/sources/auth_query.c
@@ -142,10 +142,13 @@ int od_auth_query(od_client_t *client, char *peer)
 			 user->name_len, user->name);
 		/* unlock hashmap entry */
 		password->password_len = cache_value->passwd_len;
-		password->password = malloc(password->password_len + 1);
-		strncpy(password->password, cache_value->passwd,
-			cache_value->passwd_len);
-		password->password[password->password_len] = '\0';
+		if (cache_value->passwd_len > 0) {
+			/*  */
+			password->password = malloc(password->password_len + 1);
+			strncpy(password->password, cache_value->passwd,
+				cache_value->passwd_len);
+			password->password[password->password_len] = '\0';
+		}
 		od_hashmap_unlock_key(storage->acache, keyhash, &key);
 		return OK_RESPONSE;
 	}