Added config testing (odyssey --test) #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaUnisikhin
force-pushed
the
od_conf_validation
branch
2 times, most recently
from
688d2a2 to
38599b8
Compare
NikitaUnisikhin
force-pushed
the
od_conf_validation
branch
from
38599b8 to
b4d026d
Compare
NikitaUnisikhin
force-pushed
the
od_conf_validation
branch
from
c55ab38 to
e0a3922
Compare
reshke
reviewed
Nov 7, 2023
|
|
||
| log_format "%p %t %l [%i %s] (%c) %m\n" | ||
|
|
||
| listen { |
There was a problem hiding this comment.
maybe configs without any rules should not be valid, as they are not usable?
reshke
reviewed
Nov 7, 2023
config-examples/odyssey-aq.conf
Outdated
| @@ -117,6 +117,7 @@ database "postgres" { | |||
| auth_query_db "postgres" | |||
| storage_password "passwd" | |||
|
|
|||
| storage "postgres_server" | |||
reshke
reviewed
Nov 7, 2023
reshke
reviewed
Nov 8, 2023
reshke
approved these changes
Nov 9, 2023
NikitaUnisikhin
added a commit
to NikitaUnisikhin/odyssey
that referenced
this pull request
Nov 20, 2023
* added configuration testing (odyssey --test) * fixes * fix names * fix names * apply fmt * start create tests * rebuild * tests done * --test no longer forks the process * config without rules is no longer valid * fix tests * fix storage_type tests * fix storage_tls tests * fix config-examples/odyssey-aq.conf * change .gitignore * rm .DS_Store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.