Add groups #559
Add groups #559
Conversation
sources/group.h
Outdated
| char *storage_db; | ||
|
|
||
| char *group_name; | ||
| int group_name_len; |
There was a problem hiding this comment.
it seems that this field of structure exists only in order to exist :)
There was a problem hiding this comment.
thanks, fixed
| @@ -0,0 +1,32 @@ | |||
| /* | |||
There was a problem hiding this comment.
add "#ifndef" + "define" for new headers
There was a problem hiding this comment.
thanks, fixed
sources/group.h
Outdated
|
|
||
| int od_group_free(od_group_t *); | ||
| void od_group_qry_format(char *, char *, ...); | ||
| int od_group_parse_val_datarow(machine_msg_t *, int *); |
There was a problem hiding this comment.
thanks, fixed
sources/rules.c
Outdated
| { | ||
| /* Allocate and force defaults */ | ||
| od_group_t *group; | ||
| group = (od_group_t *)malloc(sizeof(*group)); |
There was a problem hiding this comment.
no need cast it to (od_group_t *), in C you don't need it
There was a problem hiding this comment.
thanks, fixed
sources/rules.c
Outdated
| group = (od_group_t *)malloc(sizeof(*group)); | ||
| if (group == NULL) | ||
| return NULL; | ||
| memset(group, 0, sizeof(*group)); |
There was a problem hiding this comment.
use calloc() at line 132 (its faster + the clearest way to allocate a buffer which filled with 0)
There was a problem hiding this comment.
thanks, fixed
| /* (not used) */ | ||
| uint32_t val_len; | ||
| rc = kiwi_read32(&val_len, &pos, &pos_size); | ||
| if (kiwi_unlikely(rc == -1)) { |
There was a problem hiding this comment.
same issue as at line 59 (read from same position)
There was a problem hiding this comment.
why is this better?
| goto error; | ||
| /* count */ | ||
| uint16_t count; | ||
| rc = kiwi_read16(&count, &pos, &pos_size); |
There was a problem hiding this comment.
are you sure that you should read from pos? you have already read 4 bytes of "size" variable from here?
There was a problem hiding this comment.
in kiwi_read16 the pos pointer changes
|
|
||
| /* (not used) */ | ||
| uint32_t val_len; | ||
| rc = kiwi_read32(&val_len, &pos, &pos_size); |
There was a problem hiding this comment.
val_len is the same to size because you read it from same position
There was a problem hiding this comment.
in kiwi_read16 the pos pointer changes
sources/config_reader.c
Outdated
| @@ -1203,7 +1209,8 @@ od_config_reader_ldap_storage_credentials(od_config_reader_t *reader, | |||
| static int od_config_reader_rule_settings(od_config_reader_t *reader, | |||
| od_rule_t *rule, | |||
| od_extention_t *extentions, | |||
| od_storage_watchdog_t *watchdog) | |||
| od_storage_watchdog_t *watchdog, | |||
| od_group_t *group) | |||
There was a problem hiding this comment.
why you gives group as argument? you have already had it in "od_rule_t *rule"
There was a problem hiding this comment.
thanks, fixed
| NULL); | ||
| } | ||
|
|
||
| static int od_config_reader_group(od_config_reader_t *reader, char *db_name, |
There was a problem hiding this comment.
default way to write and use od_config_reader_something it is to give reader and pointer to struct/variable where you should read
look at od_config_reader_string or od_config_reader_number64 or od_config_reader_keyword
lets give in arguments od_group_t* ?
There was a problem hiding this comment.
thanks, fixed
NikitaUnisikhin
force-pushed
the
add_groups
branch
from
a9398a9 to
f9160fe
Compare
| return NOT_OK_RESPONSE; | ||
| } | ||
|
|
||
| machine_sleep(1000); |
docker/group/config.conf
Outdated
|
|
||
| pool_routing "internal" | ||
| pool "session" | ||
| group_query "select pg_has_role('%s', 'group1', 'MEMBER')" |
There was a problem hiding this comment.
Do we need to specify group_query at all ?
We may just set as default during configuration, using group name for current route.
Is there any alternatives to this one ^^
…ers, and not on whether the participant belongs to a specific group
NikitaUnisikhin
force-pushed
the
add_groups
branch
from
597dad5 to
40cbb0f
Compare
-- added group authentication