Merge pull request #1131 from yast/self_update_fix_SP7

[SLE15-SP7] Fixed comparing versions in the self-update version check
yast · Dec 17, 2024 · e95ed3f · e95ed3f
2 parents e6ebc98 + 0c32a84
commit e95ed3f
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 2 deletions.
diff --git a/package/yast2-installation.changes b/package/yast2-installation.changes
@@ -1,3 +1,16 @@
+-------------------------------------------------------------------
+Tue Dec 17 15:05:22 UTC 2024 - Ladislav Slezák <[email protected]>
+
+- Self-update fix (bsc#1234661)
+  - Properly compare the package versions from the inst-sys and
+    the self-update repository
+  - Remove the architecture suffix when reading the package version
+    from the inst-sys (the /.packages.root file)
+  - This fixes false alarm about incorrect self-update repository
+    when the installation is booted from PXE using the updated
+    tftpboot-installation-* packages (not the GA version)
+- 4.7.2
+
 -------------------------------------------------------------------
 Wed Oct 23 11:18:09 UTC 2024 - Josef Reidinger <[email protected]>
 

diff --git a/package/yast2-installation.spec b/package/yast2-installation.spec
@@ -16,7 +16,7 @@
 #
 
 Name:           yast2-installation
-Version:        4.7.1
+Version:        4.7.2
 Release:        0
 Summary:        YaST2 - Installation Parts
 License:        GPL-2.0-only

diff --git a/src/lib/installation/instsys_packages.rb b/src/lib/installation/instsys_packages.rb
@@ -27,6 +27,9 @@ def self.read(file = "/.packages.root")
         name, version = /^(\S+) \[(\S+)\]/.match(line)[1, 2]
         next unless name && version
 
+        # remove the architecture suffix
+        version.sub!(/\.(noarch|aarch64|i[3-6]86|ppc64|ppc64le|s390x?|x86_64)$/, "")
+
         # nil repository ID
         packages << Y2Packager::Package.new(name, nil, version)
       end

diff --git a/test/instsys_packages_test.rb b/test/instsys_packages_test.rb
@@ -29,9 +29,15 @@
 
     it "reads the package versions" do
       pkgs = Installation::InstsysPackages.read(test_file)
+
       yast2 = pkgs.find { |p| p.name == "yast2" }
+      yast2_add_on = pkgs.find { |p| p.name == "yast2-add-on" }
+
+      # no "x86_64" suffix
+      expect(yast2.version).to eq("4.2.67-1.7")
 
-      expect(yast2.version).to eq("4.2.67-1.7.x86_64")
+      # no "noarch" suffix
+      expect(yast2_add_on.version).to eq("4.2.15-1.30")
     end
   end
 end