Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLE15-SP5] Refresh repositories with changed URL and reload them again #1098

Merged
merged 1 commit into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions package/yast2-installation.changes
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
Fri Oct 27 14:13:14 UTC 2023 - Ladislav Slezák <[email protected]>

- Refresh repositories with changed URL and reload them again
to activate the changes (related to bsc#1215884)
- 4.5.18

-------------------------------------------------------------------
Thu Jun 15 15:01:13 UTC 2023 - Stefan Hundhammer <[email protected]>

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-installation.spec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#

Name: yast2-installation
Version: 4.5.17
Version: 4.5.18
Release: 0
Summary: YaST2 - Installation Parts
License: GPL-2.0-only
Expand Down
4 changes: 4 additions & 0 deletions src/lib/installation/clients/inst_upgrade_urls.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

require "yast"
require "installation/upgrade_repo_manager"
require "y2packager/medium_type"
require "y2packager/repository"

Yast.import "GetInstArgs"
Expand Down Expand Up @@ -297,6 +298,9 @@ def save_pkg_mgr
# do not save the changes in the test mode
Pkg.SourceSaveAll unless test?

# reload repositories only when using the openSUSE Leap media
Pkg.SourceLoad if Y2Packager::MediumType.standard?

# clear the old repositories
Y2Packager::OriginalRepositorySetup.instance.repositories.clear
end
Expand Down
9 changes: 9 additions & 0 deletions src/lib/installation/upgrade_repo_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ def activate_changes
update_urls
process_repos
remove_services

# reload the package manager to activate the changes
Yast::Pkg.SourceSaveAll
Yast::Pkg.SourceFinishAll
Yast::Pkg.SourceRestore
Yast::Pkg.SourceLoad
end

private
Expand Down Expand Up @@ -167,6 +173,9 @@ def process_repos
def update_urls
new_urls.each do |repo, url|
repo.url = url

# if the repository will be enabled refresh the content
Yast::Pkg.SourceForceRefreshNow(repo.repo_id) if status_map[repo] == :enabled
end
end

Expand Down
2 changes: 2 additions & 0 deletions test/lib/clients/inst_upgrade_urls_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
allow(Yast::UI).to receive(:QueryWidget)
allow(Yast::UI).to receive(:ChangeWidget)
allow(Yast::Pkg).to receive(:SourceSaveAll)
allow(Y2Packager::MediumType).to receive(:standard?).and_return(true)
allow(Yast::Pkg).to receive(:SourceLoad)
end

describe "#main" do
Expand Down
4 changes: 4 additions & 0 deletions test/lib/upgrade_repo_manager_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ def self.is_registered?
allow(repo1).to receive(:disable!)
allow(repo1).to receive(:delete!)
allow(Yast::Pkg).to receive(:ServiceDelete)
allow(Yast::Pkg).to receive(:SourceSaveAll)
allow(Yast::Pkg).to receive(:SourceFinishAll)
allow(Yast::Pkg).to receive(:SourceRestore)
allow(Yast::Pkg).to receive(:SourceLoad)
end

it "removes the selected repositories" do
Expand Down
Loading