WIP: Handle autoinst AND autoupgrade (bsc#1222153) [SLE-15-SP5]

[shundhammer]

Target Branch

This is for SLE-15-SP5. A merge to SLE-15-SP6 and to master will follow.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1222153

Problem

In AutoYaST upgrade mode, the halt instruction doesn't work:

<general>
  <mode>
    <halt config:type="boolean">false</halt>
  </mode>
  ...
</general>

Cause

The code only checked for Mode.autoinst, not also for Mode.autoupgrade, or, more generally, for Mode.auto which checks for both.

Fix

Check for Mode.auto, not just for Mode.autoinst.

Test

This is intended as a DUD for the customer to test.

Related PRs

• Merge to SLE-15-SP6: TBD
• Merge to master: TBD

[coveralls]

coverage: 40.913% (-0.2%) from 41.105%
when pulling c08ae16 on l3-1222153-halt
into d1471c9 on master.

[shundhammer]

No idea why coveralls thinks the coverage decreased. It's just a one-word change.

[shundhammer]

The L3 customer was happy enough with the workaround.

This begs the question if we still want to do this code change, and if yes, in what branches.

[jreidinger]

BTW for SP7 and master it is handled in #1129 and #1132 where openqa require slight modification in behavior.