Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLE15-SP6] Fixed comparing versions in the self-update version check #1130

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Dec 17, 2024

Problem

broken_self_update

  • https://bugzilla.suse.com/show_bug.cgi?id=1234661
  • YaST displays a false alarm error, there is actually no problem with the self-update repository
  • The problem was in reading the versions from the /.packages.root file, the package version additionally contains the architecture at the end
  • When comparing versions the "4.6.5-150600.3.6.1" version from the self-update looks older as "4.6.5-150600.3.6.1.x86_64" from the inst-sys so then YaST complains about downgrade
  • This happens only when the installation is booted from PXE using the updated tftpboot-installation-* packages (not the GA version, that works fine)

Solution

  • Remove the architecture suffix from the version

Testing

  • Updated unit test
  • Tested manually by the SUMA team

from the version when reading the /.packages.root file from the inst-sys
@coveralls
Copy link

Coverage Status

coverage: 40.927% (+0.005%) from 40.922%
when pulling c1246bc on self_update_fix_SP6
into 0851b52 on SLE-15-SP6.

@lslezak lslezak merged commit 10b3723 into SLE-15-SP6 Dec 17, 2024
12 checks passed
@lslezak lslezak deleted the self_update_fix_SP6 branch December 17, 2024 15:52
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #10 successfully finished
✔️ Created IBS submit request #356183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants