Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sp7 #1132

Merged
merged 12 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions package/yast2-installation.changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
-------------------------------------------------------------------
Tue Dec 17 15:56:21 UTC 2024 - Josef Reidinger <[email protected]>

- skip showing reboot message in autoinstallation and
autoupgrade mode only if not explicitly set on command line
(bsc#1231522)
- 5.0.16

-------------------------------------------------------------------
Tue Dec 17 15:05:22 UTC 2024 - Ladislav Slezák <[email protected]>

- Self-update fix (bsc#1234661)
- Properly compare the package versions from the inst-sys and
the self-update repository
- Remove the architecture suffix when reading the package version
from the inst-sys (the /.packages.root file)
- This fixes false alarm about incorrect self-update repository
when the installation is booted from PXE using the updated
tftpboot-installation-* packages (not the GA version)

-------------------------------------------------------------------
Wed Oct 23 11:18:09 UTC 2024 - Josef Reidinger <[email protected]>

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-installation.spec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#

Name: yast2-installation
Version: 5.0.15
Version: 5.0.16
Release: 0
Summary: YaST2 - Installation Parts
License: GPL-2.0-only
Expand Down
5 changes: 4 additions & 1 deletion src/lib/installation/clients/inst_finish.rb
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ def write

def report_messages
return if Misc.boot_msg.empty?
return if Mode.auto

# --------------------------------------------------------------
# Check if there is a message left to display
Expand All @@ -148,6 +147,10 @@ def report_messages
if Linuxrc.reboot_timeout
Report.DisplayMessages(true, Linuxrc.reboot_timeout)
else
# Skip in autoinstallation and autoupgrade mode only if not explicitly
# set on command line (bsc#1231522)
return if Mode.auto

# Display the message and wait for user to accept it
# also live installation - bzilla #297691
Report.DisplayMessages(true,
Expand Down
3 changes: 3 additions & 0 deletions src/lib/installation/instsys_packages.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ def self.read(file = "/.packages.root")
name, version = /^(\S+) \[(\S+)\]/.match(line)[1, 2]
next unless name && version

# remove the architecture suffix
version.sub!(/\.(noarch|aarch64|i[3-6]86|ppc64|ppc64le|s390x?|x86_64)$/, "")

# nil repository ID
packages << Y2Packager::Package.new(name, nil, version)
end
Expand Down
8 changes: 7 additions & 1 deletion test/instsys_packages_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,15 @@

it "reads the package versions" do
pkgs = Installation::InstsysPackages.read(test_file)

yast2 = pkgs.find { |p| p.name == "yast2" }
yast2_add_on = pkgs.find { |p| p.name == "yast2-add-on" }

# no "x86_64" suffix
expect(yast2.version).to eq("4.2.67-1.7")

expect(yast2.version).to eq("4.2.67-1.7.x86_64")
# no "noarch" suffix
expect(yast2_add_on.version).to eq("4.2.15-1.30")
end
end
end
Loading