Fix shell wrapper for PowerShell #195
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This makes sure that `GetFullPath` gets evaluated before passing its value to `Set-Location`. This prevents `Set-Location` from raising an error "A positional parameter cannot be found that accepts argument 'C:\path\to\dir'".
spenserblack
force-pushed
the
bugfix/powershell-cd
branch
from
fa965b5 to
14a90c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that
GetFullPathgets evaluated before passing its value toSet-Location. This preventsSet-Locationfrom raising an error "A positional parameter cannot be found that accepts argument 'C:\path\to\dir'".I received this error on both PowerShell and Windows PowerShell (yes, there's a difference 😅). Additionally I double-checked if there was any difference between PowerShell on Linux and on Windows, just to see if this was somehow OS-specific. This changed resolved the issue for both Windows PowerShell and PowerShell.
Related: #191