Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with base package #70

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Sync with base package #70

merged 6 commits into from
Dec 7, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️

@arogachev arogachev marked this pull request as draft December 6, 2023 12:06
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (d8656b5) 99.47% compared to head (d2cb093) 90.00%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/ItemsStorage.php 88.57% 12 Missing ⚠️
src/AssignmentsStorage.php 93.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     99.47%   90.00%   -9.48%     
- Complexity       83      128      +45     
============================================
  Files             3        3              
  Lines           192      300     +108     
============================================
+ Hits            191      270      +79     
- Misses            1       30      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev self-assigned this Dec 6, 2023
@arogachev arogachev added the type:enhancement Enhancement label Dec 6, 2023
Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Addition of getByNames() and getAccessTree() methods in ItemsStorage
    These new methods will provide additional ways to retrieve data from storage, increasing the flexibility of how our application handles data.

  • Introduction of filterUserItemNames() method in AssignmentsStorage
    This method will filter user item names stored in our storage. This will improve how we manage and utilize user-specific data.

  • Refactor of argument name and type in ItemsStorage
    The argument $name in methods getAllChildren(), getAllChildRoles(), and getAllChildPermissions() has been renamed to $names and its type has been changed to array. This will allow these methods to accept and handle multiple names at once, making them more efficient.

@arogachev arogachev added the type:task Task label Dec 6, 2023
@arogachev arogachev marked this pull request as ready for review December 7, 2023 13:48
@arogachev arogachev merged commit cc918c1 into master Dec 7, 2023
18 of 20 checks passed
@arogachev arogachev deleted the base-sync branch December 7, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant