Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simple storages, PHP 8.1 and PHPUnit 10.5.2 #76

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Copy link

what-the-diff bot commented Dec 12, 2023

PR Summary

  • Enhancement of the ItemsStorage and AssignmentsStorage Functionalities

    • Implemented new methods getByNames() and getAccessTree() to fetch items in the ItemsStorage.
    • Implemented a new method filterUserItemNames() in AssignmentsStorage to filter user items.
    • Modified some methods in ItemsStorage to now accept arrays and have more descriptive argument names.
  • Updates in Package and Testing Requirements

    • Updated the required PHP version and the PHPUnit tool in the project’s package file (composer.json).
    • Addition of test bootstrap file to the autoload section in composer.json to ensure required classes are properly loaded during testing.
  • Improvements in Testing Configurations

    • Certain attribute settings were removed and new ones were added to the PHPUnit configuration file for improving testing.
  • Enhancements in the AssignmentsStorage File

    • Enhanced the structure and functionality of AssignmentsStorage.php by extending the class, removing/deleting properties and methods, and modifying methods for better functionality.
  • Renaming and Refactoring

    • Renamed the CommonStorage.php file to FileStorageTrait.php for better understanding of its function.
  • Enhancements in the ItemsStorage File

    • Similar to AssignmentsStorage, ItemsStorage.php has been upgraded by extending the class, removing/deleting properties and methods, and modifying methods for improved functionality.
  • Test Files Setup

    • Added bootstrap.php file to the test directory for setting up the environment before running tests.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc918c1) 90.00% compared to head (06df6f2) 76.03%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #76       +/-   ##
=============================================
- Coverage     90.00%   76.03%   -13.97%     
+ Complexity      128       48       -80     
=============================================
  Files             3        3               
  Lines           300      121      -179     
=============================================
- Hits            270       92      -178     
+ Misses           30       29        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev merged commit 4fe27e0 into master Dec 12, 2023
16 of 17 checks passed
@arogachev arogachev deleted the base-sync-2 branch December 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants