-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert middleware to request handler #79
Conversation
xepozz
commented
Jun 17, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ✔️ |
PR Summary
|
src/Middleware/SwaggerJson.php
Outdated
use Psr\Http\Server\RequestHandlerInterface; | ||
use Yiisoft\Cache\CacheInterface; | ||
use Yiisoft\DataResponse\DataResponseFactoryInterface; | ||
use Yiisoft\Swagger\Service\SwaggerService; | ||
|
||
final class SwaggerJson implements MiddlewareInterface | ||
final class SwaggerJson implements RequestHandlerInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What's the benefit?
- It's still in the
Middleware
namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move it outside of the middleware
folder
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
=============================================
- Coverage 92.85% 66.66% -26.20%
- Complexity 20 28 +8
=============================================
Files 5 7 +2
Lines 70 105 +35
=============================================
+ Hits 65 70 +5
- Misses 5 35 +30
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need fix readme
@xepozz readme should be adjusted. Afterwards, it's good to merge. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need add configuration of new actions to di-web.php
.