add support for chinese lang #33
Conversation
There was a problem hiding this comment.
@subframe7536 Thank you for your contribution!
Please see my comment below 🙂
| @@ -20,7 +20,7 @@ export const formatDiagnosticMessage = (message: string, format: (type: string) | |||
| message | |||
| // format declare module snippet | |||
| .replaceAll( | |||
| /'(declare module )'(.*)';'/g, | |||
| /['“](declare module )['”](.*)['“];['”]/g, | |||
There was a problem hiding this comment.
It should be better to replace all the “ characters by ' at the beginning in one replace instead of adding it to all the others.
WDYT?
There was a problem hiding this comment.
I thought the same way, but I can't guarantee that all “” inside error messages are just used as the replacement of ''
There was a problem hiding this comment.
I didn't see ” inside a type before, but I didn't use the Chinese language pack so we'll go with the safe option for now 🙂
Thank you!
| @@ -20,7 +20,7 @@ export const formatDiagnosticMessage = (message: string, format: (type: string) | |||
| message | |||
| // format declare module snippet | |||
| .replaceAll( | |||
| /'(declare module )'(.*)';'/g, | |||
| /['“](declare module )['”](.*)['“];['”]/g, | |||
There was a problem hiding this comment.
I didn't see ” inside a type before, but I didn't use the Chinese language pack so we'll go with the safe option for now 🙂
Thank you!
when the extension of
Chinese (Simplified) (简体中文) Language Pack for Visual Studio Codeinstalled, it use“”to wrap the code in error hint.add support for it