Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove source backflow feature #683

Merged
merged 2 commits into from
Dec 15, 2023
Merged

feat: remove source backflow feature #683

merged 2 commits into from
Dec 15, 2023

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Dec 11, 2023

Description

Source Remove SetReceiveHandler() method and WithObserveDataTags Option

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 8:35am

@woorui woorui changed the title feat: remove source backflow handler feature feat: remove source backflow feature Dec 11, 2023
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (6d8b913) 59.01% compared to head (3ab925e) 58.23%.

Files Patch % Lines
core/server.go 42.30% 11 Missing and 4 partials ⚠️
core/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   59.01%   58.23%   -0.79%     
==========================================
  Files          36       35       -1     
  Lines        2706     2641      -65     
==========================================
- Hits         1597     1538      -59     
+ Misses       1009     1004       -5     
+ Partials      100       99       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woorui woorui merged commit 097e9d2 into master Dec 15, 2023
3 of 5 checks passed
@woorui woorui deleted the feat/remove-backflow branch December 15, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants