-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing nindent arg in imagePullSecrets #394
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 43.43% 43.43%
=======================================
Files 63 63
Lines 4043 4043
=======================================
Hits 1756 1756
Misses 2039 2039
Partials 248 248 ☔ View full report in Codecov by Sentry. |
@nemcikjan please bump the chart version and regenerate the Readme using https://github.com/norwoodj/helm-docs |
@yonahd when do you expect the new chart version to be released? |
Hey |
@yonahd could you please give me some estimate on this? We need it for production stuff so we can better plan the rollout of a solution based on this project. Thank you |
@johnike15 ill create a release Sunday. |
@yonahd thank you very much, really appreciate it :) |
@nemcikjan as promised a new release was published. |
@yonahd Thank you very much for help! If we'd need something in the future I'll definitely raise an issue or contribute with MR 💪 |
What this PR does / why we need it?
Fixes not working
deployment.yaml
template if usingimagePullSecrets
paramPR Checklist