Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing nindent arg in imagePullSecrets #394

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

nemcikjan
Copy link
Contributor

What this PR does / why we need it?

Fixes not working deployment.yaml template if using imagePullSecrets param

PR Checklist

  • This PR adds K8s exceptions (false positives)
  • This PR adds new code
  • This PR includes tests for new/existing code
  • This PR adds docs

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.43%. Comparing base (6d80b66) to head (0238ecf).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   43.43%   43.43%           
=======================================
  Files          63       63           
  Lines        4043     4043           
=======================================
  Hits         1756     1756           
  Misses       2039     2039           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd
Copy link
Owner

yonahd commented Dec 18, 2024

@nemcikjan please bump the chart version and regenerate the Readme using https://github.com/norwoodj/helm-docs

@yonahd yonahd merged commit eaa397f into yonahd:main Dec 18, 2024
2 checks passed
@nemcikjan
Copy link
Contributor Author

@yonahd when do you expect the new chart version to be released?

@yonahd
Copy link
Owner

yonahd commented Dec 19, 2024

@yonahd when do you expect the new chart version to be released?

Hey
Currently we don't have a process to release a new chart version separately from the application. We are looking into adding this ability but until then it will wait w the next release which should be in the next couple weeks

@johnike15
Copy link
Contributor

johnike15 commented Jan 9, 2025

@yonahd could you please give me some estimate on this? We need it for production stuff so we can better plan the rollout of a solution based on this project. Thank you

@yonahd
Copy link
Owner

yonahd commented Jan 10, 2025

@johnike15 ill create a release Sunday.

@nemcikjan
Copy link
Contributor Author

@yonahd thank you very much, really appreciate it :)

@yonahd
Copy link
Owner

yonahd commented Jan 12, 2025

@nemcikjan as promised a new release was published.
Thanks for the contribution and let me know if you have any other issues or suggestions

@nemcikjan
Copy link
Contributor Author

@yonahd Thank you very much for help! If we'd need something in the future I'll definitely raise an issue or contribute with MR 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants