Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lib.generators.toPlist #3

Merged
merged 5 commits into from
Jan 1, 2025
Merged

refactor: use lib.generators.toPlist #3

merged 5 commits into from
Jan 1, 2025

Conversation

z0al
Copy link
Owner

@z0al z0al commented Jan 1, 2025

The PR:

  • Got rid of our custom lib. I hated manual imports on every file.
  • Introduces the use of lib.generators.toPlist to generate an .plist file per domain that can then be imported via defaults import <domain> <file>
  • Update the test setup to account for ☝🏻 . I'm doing some surgical rg -> jc --plist -> jq on the test helpers but it all works fine. I even managed to come up with a DSL-like syntax that I like a lot e.g.
Domain <domain>      # Sets context for the follow-up "Set" and "Del" asserts.
Set <attr> <value>   # Asserts the <attr> is set with given <value>
Del <attr>           # Asserts the <attr> is deleted 

@z0al z0al marked this pull request as ready for review January 1, 2025 22:22
@z0al z0al merged commit 95dac0e into main Jan 1, 2025
1 check passed
@z0al z0al deleted the write-plist-v2 branch January 1, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant