Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use platform helpers to set defaults #4

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

z0al
Copy link
Owner

@z0al z0al commented Jan 2, 2025

Replace our internal logic in favor of using nix-darwin's system.defaults.CustomUserPreferences or home-manager's targets.darwin.defaults.

We still take care of deletion as usual. Nothing changed functionality-wise.

Why?

  • Less logic to maintain
  • Slightly easier to spot conflicts e.g. if a user sets a value with plist-manager and a different one with system.defaults.CustomUserPreferences nix should catch that during build.

@z0al z0al merged commit c82c2e3 into main Jan 2, 2025
1 check passed
@z0al z0al deleted the use-platform-defaults-helper branch January 2, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant