Skip to content

Commit

Permalink
chore(ci): rename steps to more meaningful names
Browse files Browse the repository at this point in the history
there was no teardown at the end, but the instance was actually started and stopped at the end.
  • Loading branch information
youben11 authored Jan 10, 2025
1 parent 43150a5 commit 232314d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/concrete_compiler_test_cpu_distributed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

jobs:
setup-instance:
start-instance:
runs-on: ubuntu-latest
steps:
- name: Start instance
Expand All @@ -38,8 +38,8 @@ jobs:

build-and-run-test:
# The distributed-ci runner is registered on the instance configured in the slurm-cluster profile.
# It's why we need to setup-instance
needs: setup-instance
# It's why we need to start-instance
needs: start-instance
runs-on: distributed-ci
steps:
- name: Instance cleanup
Expand Down Expand Up @@ -83,9 +83,9 @@ jobs:
SLACK_COLOR: ${{ job.status }}
SLACK_MESSAGE: "build-and-run-test finished with status: ${{ job.status }}. (${{ env.ACTION_RUN_URL }})"

teardown-instance:
needs: [ setup-instance, build-and-run-test ]
if: ${{ always() && needs.setup-instance.result != 'skipped' }}
stop-instance:
needs: [ start-instance, build-and-run-test ]
if: ${{ always() && needs.start-instance.result != 'skipped' }}
runs-on: ubuntu-latest
steps:
- name: Stop instance
Expand Down

0 comments on commit 232314d

Please sign in to comment.