comment

Signed-off-by: Austin Abro <[email protected]>

src/internal/packager/helm/chart.go

@@ -137,6 +137,10 @@ func (h *Helm) InstallOrUpgradeChart(ctx context.Context) (types.ConnectStrings,
 		})
 	}
 	if !h.chart.NoWait {
+		// This effectively doubles the amount of time a timeout can take
+		// 15 minute timeout -> 14 minutes to install -> another 14 minutes of waiting
+		// This could be avoided by creating the context in the start of the retry loop
+		// Technically would be a breaking change, in practice this is unlikely to affect anyone
 		healthChecksCtx, cancel := context.WithTimeout(ctx, h.timeout)
 		defer cancel()
 		spinner.Updatef("Running health checks")