Skip to content

Commit

Permalink
move auth back
Browse files Browse the repository at this point in the history
Signed-off-by: Austin Abro <[email protected]>
  • Loading branch information
AustinAbro321 committed Jan 7, 2025
1 parent 00eb4e4 commit f2498b4
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions .github/workflows/nightly-ecr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ jobs:
role-to-assume: ${{ secrets.AWS_NIGHTLY_ECR_ROLE }}
role-session-name: ${{ github.job || github.event.client_payload.pull_request.head.sha || github.sha }}
aws-region: us-east-1
role-duration-seconds: 1800

- name: Login to the ECR Registry
run: aws ecr-public get-login-password --region us-east-1 | ./build/zarf tools registry login --username AWS --password-stdin public.ecr.aws
role-duration-seconds: 3600

- name: Setup golang
uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
Expand All @@ -41,17 +38,9 @@ jobs:
- name: Build the Zarf binary
run: make build-cli-linux-amd

# - name: Auth with AWS
# uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
# with:
# role-to-assume: ${{ secrets.AWS_NIGHTLY_ECR_ROLE }}
# role-session-name: ${{ github.job || github.event.client_payload.pull_request.head.sha || github.sha }}
# aws-region: us-east-1
# role-duration-seconds: 3600

# NOTE: The aws cli will need to be explicitly installed on self-hosted runners
# - name: Login to the ECR Registry
# run: aws ecr-public get-login-password --region us-east-1 | ./build/zarf tools registry login --username AWS --password-stdin public.ecr.aws
- name: Login to the ECR Registry
run: aws ecr-public get-login-password --region us-east-1 | ./build/zarf tools registry login --username AWS --password-stdin public.ecr.aws

- name: Test publishing and pulling to ECR
run: go test ./src/test/nightly/ecr_publish_test.go
Expand Down

0 comments on commit f2498b4

Please sign in to comment.