Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve behavior around cluster connection during deploy #2088

Merged
merged 15 commits into from
Oct 26, 2023
Merged

fix: improve behavior around cluster connection during deploy #2088

merged 15 commits into from
Oct 26, 2023

Conversation

Noxsios
Copy link
Contributor

@Noxsios Noxsios commented Oct 19, 2023

Description

Fixes #2085

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Noxsios Noxsios linked an issue Oct 19, 2023 that may be closed by this pull request
Zarf attempting to load Kube context prior to deploy confirm #2085
Closed
@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 3350ef3
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/653ab54f4e736a000832bbfc

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Oct 25, 2023
@Racer159 Racer159 removed the needs-tests PR Label - Tests required to merge label Oct 26, 2023
@Racer159 Racer159 marked this pull request as ready for review October 26, 2023 16:19
Noxsios
Noxsios commented Oct 26, 2023
View reviewed changes
Copy link
Contributor Author

@Noxsios Noxsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Racer159
Racer159 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lucasrod16
lucasrod16 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 1926a21 into main Oct 26, 2023
20 checks passed
@Racer159 Racer159 deleted the 2085-zarf-attempting-to-load-kube-context-prior-to-deploy-confirm branch October 26, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasrod16 lucasrod16 lucasrod16 approved these changes

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zarf attempting to load Kube context prior to deploy confirm
3 participants
@Noxsios @Racer159 @lucasrod16