Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove empty directory in package tars #3396

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

AustinAbro321
Copy link
Contributor

Description

Creating a zarf package currently results in an extra directory that looks like zarf-<9-digit-number>. This is because the temp directory where the package is built is getting added to the tar file.

Relates to #2218

Checklist before merging

@AustinAbro321 AustinAbro321 requested review from a team as code owners January 13, 2025 15:18
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f7eac26
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67852eb49403bb0007e4557e

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager2/layout/package.go 0.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/packager2/layout/package.go 39.03% <0.00%> (-1.20%) ⬇️

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 1a01ac1 Jan 13, 2025
26 checks passed
@AustinAbro321 AustinAbro321 deleted the remove-extra-directory-on-create branch January 13, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants