Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to new logging format #3397

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

AustinAbro321
Copy link
Contributor

Description

This defaults to the new logging format.

Additionally, this changes zarf init to no longer print out credentials, instead a call to run zarf tools get-creds is given

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 13, 2025 16:04
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit dfb91b7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6790f5b9fdca66000858394b

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/deploy.go 0.00% 10 Missing ⚠️
src/internal/packager/helm/repo.go 0.00% 4 Missing ⚠️
src/internal/packager2/layout/sbom.go 0.00% 4 Missing ⚠️
src/cmd/root.go 0.00% 2 Missing ⚠️
src/internal/packager/helm/chart.go 0.00% 2 Missing ⚠️
src/cmd/common/viper.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/logger/logger.go 53.78% <100.00%> (ø)
src/cmd/common/viper.go 0.00% <0.00%> (ø)
src/cmd/root.go 0.00% <0.00%> (ø)
src/internal/packager/helm/chart.go 12.66% <0.00%> (ø)
src/internal/packager/helm/repo.go 25.77% <0.00%> (ø)
src/internal/packager2/layout/sbom.go 9.34% <0.00%> (-0.16%) ⬇️
src/pkg/packager/deploy.go 5.50% <0.00%> (+0.06%) ⬆️

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Let's ship it

src/cmd/root.go Show resolved Hide resolved
src/pkg/logger/logger.go Show resolved Hide resolved
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 22, 2025
@AustinAbro321 AustinAbro321 removed this pull request from the merge queue due to a manual request Jan 22, 2025
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit ff76a30 Jan 22, 2025
38 checks passed
@AustinAbro321 AustinAbro321 deleted the use-new-logging-format branch January 22, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants