adds round_to_int boolean argument to FixedScaleOffset #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2024 19:53
…ing this filter without automatically converting to integers. (zarr-developers#549)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2339 2349 +10
=======================================
+ Hits 2337 2347 +10
Misses 2 2
|
dstansby
requested changes
Nov 29, 2024
| @@ -70,10 +72,11 @@ class FixedScaleOffset(Codec): | |||
|
|
|||
| codec_id = 'fixedscaleoffset' | |||
|
|
|||
| def __init__(self, offset, scale, dtype, astype=None): | |||
| def __init__(self, offset, scale, dtype, astype=None, round_to_int=True): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, offset, scale, dtype, astype=None, round_to_int=True): | |
| def __init__(self, offset, scale, dtype, astype=None, *, round_to_int=True): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to apply this filter without automatically converting to integers. #549