Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap release notes post v3 #2680

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jan 9, 2025

This adds a new section for new release notes, and also updates the release guide to explain how to handle the release notes. The sections I chose for the release notes are very much up for change/suggestion.

1. Make sure that all pull requests which will be
included in the release have been properly documented in
:file:`docs/release-notes.rst`.
2. Rename the "Unreleased" section heading in :file:`docs/release-notes.rst`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems a bit annoying because it requires another commit before the release or am I understanding it wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right. I guess with the current system, unless we decide on the version numbering ahead of time then this is unavoidable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On other projects I've used https://towncrier.readthedocs.io/en/stable/ with success, and it was suggested a while ago here too: #829.

You still have to generate the changelog before release, but it makes having multiple branches easier (e.g., if we have a 3.0.x branch for bugfixes and main for 3.x.0 releases), and would mean the extra commit after release (your comment below) wouldn't be needed.

I'd be up for trying to set towncrier up, either instead of or after this PR?

""""""""""""

- Review and merge the pull request on the `conda-forge feedstock <https://github.com/conda-forge/zarr-feedstock>`_ that will be automatically generated.
- Create a new "Unreleased" section in the release notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another commit here?

@dstansby dstansby marked this pull request as ready for review January 9, 2025 20:58
@normanrz
Copy link
Member

Fwiw, I started release notes in #2679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants