-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap release notes post v3 #2680
base: main
Are you sure you want to change the base?
Conversation
1. Make sure that all pull requests which will be | ||
included in the release have been properly documented in | ||
:file:`docs/release-notes.rst`. | ||
2. Rename the "Unreleased" section heading in :file:`docs/release-notes.rst` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems a bit annoying because it requires another commit before the release or am I understanding it wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's right. I guess with the current system, unless we decide on the version numbering ahead of time then this is unavoidable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On other projects I've used https://towncrier.readthedocs.io/en/stable/ with success, and it was suggested a while ago here too: #829.
You still have to generate the changelog before release, but it makes having multiple branches easier (e.g., if we have a 3.0.x branch for bugfixes and main
for 3.x.0 releases), and would mean the extra commit after release (your comment below) wouldn't be needed.
I'd be up for trying to set towncrier up, either instead of or after this PR?
"""""""""""" | ||
|
||
- Review and merge the pull request on the `conda-forge feedstock <https://github.com/conda-forge/zarr-feedstock>`_ that will be automatically generated. | ||
- Create a new "Unreleased" section in the release notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And another commit here?
Fwiw, I started release notes in #2679 |
This adds a new section for new release notes, and also updates the release guide to explain how to handle the release notes. The sections I chose for the release notes are very much up for change/suggestion.