Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable codecov in main test action #2682

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jan 10, 2025

Closes #2613

TODO:

  • GitHub Actions have all passed

@zarr-developers zarr-developers deleted a comment from codecov bot Jan 10, 2025
@jhamman
Copy link
Member Author

jhamman commented Jan 10, 2025

This is working. We may need to merge with codecov check failing because it is comparing against eaf5d7a which is way back in v2 land. Going forward, subsequent checks should compare against main and the behavior should be that the check will only fail if the coverage goes down.

@jhamman jhamman requested review from dstansby and d-v-b January 10, 2025 14:46
@d-v-b d-v-b enabled auto-merge (squash) January 10, 2025 14:55
@d-v-b d-v-b merged commit 0e1fde4 into zarr-developers:main Jan 10, 2025
29 of 30 checks passed
@jhamman jhamman deleted the fix/codecov branch January 10, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Bring back Codecov?
2 participants