network_cache_size_bytes == 0 will totally disable the cache

zas · Apr 11, 2024 · e6c65b7 · e6c65b7
1 parent 40856d9
commit e6c65b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/picard/ui/options/network.py b/picard/ui/options/network.py
@@ -113,7 +113,7 @@ def display2cachesize(self, config):
             cache_size = int(self.ui.network_cache_size.text())
         except ValueError:
             return
-        if cache_size > 0:
+        if cache_size >= 0:
             config.setting['network_cache_size_bytes'] = int(cache_size * CACHE_SIZE_DISPLAY_UNIT)
 
     def cachesize2display(self, config):
@@ -123,7 +123,7 @@ def cachesize2display(self, config):
             cache_size = -1
 
         value = int(cache_size / CACHE_SIZE_DISPLAY_UNIT)
-        if cache_size <= 0:
+        if cache_size < 0:
             value = CACHE_SIZE_IN_BYTES
         self.ui.network_cache_size.setText(str(value))
 

diff --git a/picard/webservice/__init__.py b/picard/webservice/__init__.py
@@ -392,6 +392,9 @@ def _init_timers(self):
     def set_cache(self, cache_size_in_bytes=None):
         if cache_size_in_bytes is None:
             cache_size_in_bytes = CACHE_SIZE_IN_BYTES
+        if cache_size_in_bytes <= 0:
+            log.debug("NetworkDiskCache disabled")
+            return
         cache = QtNetwork.QNetworkDiskCache()
         cache.setCacheDirectory(os.path.join(appdirs.cache_folder(), 'network'))
         cache.setMaximumCacheSize(cache_size_in_bytes)