Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script parser tests #17

Merged
merged 1 commit into from
May 10, 2024

Conversation

phw
Copy link

@phw phw commented May 10, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

This is an attempt to fix the tests for metabrainz#2461

When importing from picard.extension_points.script_functions import ext_point_script_functions in one file and then patching picard.extension_points.script_functions import ext_point_script_functions in the tests we ended up with two distinct instances of ExtensionPoint, one in the file that imported ext_point_script_functions and a new one in picard.extension_points.script_functions .

By instead importing import picard.extension_points.script_functions` patching the object inside script_functions makes the patched object available in the importing file as well.

@zas zas merged commit 5e497d5 into zas:group_extension_points May 10, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants