Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
This is an attempt to fix the tests for metabrainz#2461
When importing
from picard.extension_points.script_functions import ext_point_script_functions
in one file and then patchingpicard.extension_points.script_functions import ext_point_script_functions
in the tests we ended up with two distinct instances ofExtensionPoint
, one in the file that importedext_point_script_functions
and a new one inpicard.extension_points.script_functions
.By instead importing import picard.extension_points.script_functions` patching the object inside script_functions makes the patched object available in the importing file as well.