Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mount TMP directories for Singularity #78

Closed
wants to merge 3 commits into from
Closed

Conversation

ninsch3000
Copy link
Contributor

Error was raised in htsinfer, as tmp directory could not be created.

Mounting the os tmp dir in the corresponding singularity container fixed this

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added Google-style
    docstrings

    to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

@uniqueg uniqueg changed the title Mount tmp feat: mount TMP directories for Singularity Jan 31, 2024
@uniqueg uniqueg changed the title feat: mount TMP directories for Singularity fix: mount TMP directories for Singularity Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9503aa) 100.00% compared to head (a61548b) 100.00%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1261      1263    +2     
=========================================
+ Hits          1261      1263    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ninsch3000 ninsch3000 closed this Jan 31, 2024
@ninsch3000 ninsch3000 deleted the mount_tmp branch January 31, 2024 17:52
@ninsch3000 ninsch3000 restored the mount_tmp branch January 31, 2024 17:52
@uniqueg uniqueg deleted the mount_tmp branch January 31, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants