Test with bundled prover instead of local prover. #1017
Conversation
nuttycom
force-pushed
the
test_with_bundled_prover
branch
from
6a45221 to
3cdb005
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
| - name: Fetch path to Zcash parameters | ||
| working-directory: ./zcash_proofs | ||
| shell: bash | ||
| run: echo "ZCASH_PARAMS=$(cargo run --release --example get-params-path --features directories)" >> $GITHUB_ENV |
There was a problem hiding this comment.
We can delete the get-params-path example now; it was only added for use in our CI. (However, we should verify that zebrad's CI isn't also using it; I think they might have been at one stage.)
There was a problem hiding this comment.
git grep shows no usage of get-params-path in the zebrad repo.
There was a problem hiding this comment.
Aha, what they actually did is copied those files into their CI. They removed their copies in ZcashFoundation/zebra#7800.
There was a problem hiding this comment.
So yes, we can just remove zcash_proofs/examples/ entirely (I don't think we need to offer Sprout parameter downloading examples either).
| - name: Fetch Zcash parameters | ||
| if: steps.cache-params.outputs.cache-hit != 'true' | ||
| working-directory: ./zcash_proofs | ||
| run: cargo run --release --example download-params --features download-params |
There was a problem hiding this comment.
We can delete the download-params example now; it was only added for use in our CI. (However, we should verify that zebrad's CI isn't also using it; I think they might have been at one stage.)
There was a problem hiding this comment.
git grep shows no usage of download-params in the zebrad repo.
…default. `fetch_params.sh` is now deprecated and the bundled proving parameters from `wagyu-zcash-parameters` are used everywhere, so the tests should follow suit. Fixes zcash#1016
Now that the tests use the bundled prover, we no longer need them to download the zcash parameters files.
Since we now use the bundled prover everywhere, we no longer need utilities to download Zcash parameters, which was the only purpose that these examples were serving.
nuttycom
force-pushed
the
test_with_bundled_prover
branch
from
3cdb005 to
c0a0ef1
Compare
No description provided.