Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests to pipeline version removal #21

Merged
merged 2 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ zenml model list

This will show you a new `breast_cancer_classifier` model with two versions, `sgd` and `rf` created. You can find out how this was configured in the [YAML pipeline configuration files](configs/).

If you are a [ZenML Cloud](https://zenml.io/cloud) user, you can see all of this visualized in the dashboard:
If you are a [ZenML Pro](https://zenml.io/pro) user, you can see all of this visualized in the dashboard:

<img src=".assets/cloud_mcp_screenshot.png" width="70%" alt="Model Control Plane">

Expand All @@ -165,7 +165,7 @@ While we've demonstrated a manual promotion process for clarity, a more in-depth

<img src=".assets/cloud_mcp.png" width="60%" alt="Model Control Plane">

Again, if you are a [ZenML Cloud](https://zenml.io/cloud) user, you would be able to see all this in the cloud dashboard.
Again, if you are a [ZenML Pro](https://zenml.io/pro) user, you would be able to see all this in the cloud dashboard.

</details>

Expand All @@ -184,7 +184,7 @@ that were returned in the pipeline. This completes the MLOps loop of training to

<img src=".assets/inference_pipeline.png" width="45%" alt="Inference pipeline">

You can also see all predictions ever created as a complete history in the dashboard (Again only for [ZenML Cloud](https://zenml.io/cloud) users):
You can also see all predictions ever created as a complete history in the dashboard (Again only for [ZenML Pro](https://zenml.io/pro) users):

<img src=".assets/cloud_mcp_predictions.png" width="70%" alt="Model Control Plane">

Expand All @@ -203,7 +203,7 @@ If you want to learn more about ZenML as a tool, then the
to get started. In particular, the [Production Guide](https://docs.zenml.io/user-guide/production-guide/)
goes into more detail as to how to transition these same pipelines into production on the cloud.

The best way to get a production ZenML instance up and running with all batteries included is the [ZenML Cloud](https://zenml.io/cloud). Check it out!
The best way to get a production ZenML instance up and running with all batteries included is the [ZenML Pro](https://zenml.io/pro). Check it out!

Also, make sure to join our <a href="https://zenml.io/slack" target="_blank">
<img width="15" src="https://cdn3.iconfinder.com/data/icons/logos-and-brands-adobe/512/306_Slack-512.png" alt="Slack"/>
Expand Down
12 changes: 6 additions & 6 deletions template/quickstart.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@
"id": "966ce581",
"metadata": {},
"source": [
"## ☁️ Step 1: Connect to ZenML Cloud\n",
"## ☁️ Step 1: Connect to ZenML Pro\n",
"\n",
"If you are using [ZenML Cloud](https://zenml.io/cloud), execute the following\n",
"If you are using [ZenML Pro](https://zenml.io/pro), execute the following\n",
"cell with your tenant URL. Otherwise ignore.\n",
"\n",
"ZenML Cloud is a managed service that provides a hosted ZenML environment. It\n",
"ZenML Pro is a managed service that provides a hosted ZenML environment. It\n",
"allows you to run your pipelines on the cloud, manage your metadata, and\n",
"collaborate with your team. Sign up at [ZenML Cloud](https://zenml.io/cloud) for\n",
"collaborate with your team. Sign up [here](https://zenml.io/pro) for\n",
"a free trial and to get started!"
]
},
Expand Down Expand Up @@ -858,7 +858,7 @@
"id": "53517a9a",
"metadata": {},
"source": [
"If you are a [ZenML Cloud](https://zenml.io/cloud) user, you can see all of this visualized in the dashboard:\n",
"If you are a [ZenML Pro](https://zenml.io/pro) user, you can see all of this visualized in the dashboard:\n",
"\n",
"<img src=\".assets/cloud_mcp_screenshot.png\" width=\"70%\" alt=\"Model Control Plane\">"
]
Expand Down Expand Up @@ -1102,7 +1102,7 @@
"## What next?\n",
"\n",
"* If you have questions or feedback... join our [**Slack Community**](https://zenml.io/slack) and become part of the ZenML family!\n",
"* If you want to quickly get started with ZenML, check out the [ZenML Cloud](https://zenml.io/cloud)."
"* If you want to quickly get started with ZenML, check out [ZenML Pro](https://zenml.io/pro)."
]
}
],
Expand Down
10 changes: 7 additions & 3 deletions tests/test_starter_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def generate_and_run_project(
"--training-pipeline",
"--feature-pipeline",
"--inference-pipeline",
"--no-cache"
"--no-cache",
]

try:
Expand All @@ -83,11 +83,15 @@ def generate_and_run_project(
) from e

# check the pipeline run is successful
for pipeline_name in ["training", "inference", "feature_engineering"]:
for pipeline_name, run_count in [
("training", 2),
("inference", 1),
("feature_engineering", 1),
]:
Comment on lines +86 to +90
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the unused variable run_count.

The loop control variable run_count is not used within the loop body. Rename it to _run_count to indicate it is intentionally unused.

- for pipeline_name, run_count in [
+ for pipeline_name, _run_count in [
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
for pipeline_name, run_count in [
("training", 2),
("inference", 1),
("feature_engineering", 1),
]:
for pipeline_name, _run_count in [
("training", 2),
("inference", 1),
("feature_engineering", 1),
]:
Tools
Ruff

86-86: Loop control variable run_count not used within loop body

Rename unused run_count to _run_count

(B007)

pipeline = Client().get_pipeline(pipeline_name)
assert pipeline
runs = pipeline.runs
assert len(runs) == 1
assert len(runs) == run_count
assert runs[0].status == ExecutionStatus.COMPLETED

# clean up
Expand Down
Loading