Removing the deprecated log_xxx_metadata calls
#27
Conversation
WalkthroughThe changes in this pull request involve modifications to the workflow configuration and the logging mechanisms in two Python files. In the workflow file Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
template/steps/model_evaluator.py (1)
Line range hint
65-80: Critical: Fix incorrect warning logicThere's a logical error in the warning implementation. Currently, warnings are only logged when the test accuracy meets the minimum requirement (due to the else block placement), which is opposite to the intended behavior described in the docstring.
Apply this fix to ensure warnings are logged when either accuracy is below minimum:
messages = [] if trn_acc < min_train_accuracy: messages.append( f"Train accuracy {trn_acc*100:.2f}% is below {min_train_accuracy*100:.2f}% !" ) if tst_acc < min_test_accuracy: messages.append( f"Test accuracy {tst_acc*100:.2f}% is below {min_test_accuracy*100:.2f}% !" ) - else: - for message in messages: - logger.warning(message) + for message in messages: + logger.warning(message)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
.github/workflows/ci.yml(1 hunks)template/steps/data_preprocessor.py(2 hunks)template/steps/model_evaluator.py(2 hunks)
🔇 Additional comments (4)
.github/workflows/ci.yml (1)
58-58: Verify the feature branch status and stability
Let's verify the existence and status of the feature branch being used.
✅ Verification successful
Based on the GitHub API results, I can now provide a final response since I have verified the status of the feature branch:
Feature branch is active and recently updated
The feature/followup-run-metadata branch exists and shows active development with the latest commit from November 13, 2024 (6f2e2245a). The branch has multiple recent commits indicating ongoing development and stability.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the status of the feature branch in ZenML repository
# Check if the branch exists and its latest commit
gh api \
-H "Accept: application/vnd.github+json" \
repos/zenml-io/zenml/branches/feature/followup-run-metadata
# Check recent commits to understand branch stability
gh api \
-H "Accept: application/vnd.github+json" \
repos/zenml-io/zenml/commits?sha=feature/followup-run-metadata&per_page=5
Length of output: 133965
template/steps/data_preprocessor.py (1)
10-10: LGTM: Import statement updated correctly
The change from log_artifact_metadata to log_metadata aligns with the PR objective to remove deprecated metadata logging calls.
template/steps/model_evaluator.py (2)
7-7: LGTM: Import updated to use new logging function
The change from log_artifact_metadata to log_metadata aligns with the PR objective of removing deprecated calls.
82-85: LGTM: Logging function updated while maintaining functionality
The change from log_artifact_metadata to log_metadata is correctly implemented, preserving the existing metadata structure and artifact naming.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor