Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change DoctrineBundle\Registry to Persistence\ManagerRegistry #100

Merged
merged 1 commit into from
Oct 28, 2024
Merged

change DoctrineBundle\Registry to Persistence\ManagerRegistry #100

merged 1 commit into from
Oct 28, 2024

Conversation

priyadi
Copy link
Contributor

@priyadi priyadi commented Sep 1, 2024

Changes the type-hint from Doctrine\Bundle\DoctrineBundle\Registry to Doctrine\Persistence\ManagerRegistry. This allows decoration of ManagerRegistry.

kbond
kbond approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@kbond kbond merged commit 53f7064 into zenstruck:1.x Oct 28, 2024
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyadi @kbond