Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: include: sof: trace: Fix the trace level setting #37

Open
wants to merge 6 commits into
base: zephyr
Choose a base branch
from

Conversation

nordic-krch
Copy link

Header has a guard to not reinclude logging header if it was already included but inside this guard there is a definition of SOF_ZEPHYR_TRACE_LEVEL which is later on used. So if log.h is already earlier included SOF_ZEPHYR_TRACE_LEVEL is not defined and compilation fails.

Moving this definition outside of the guard because if log.h is already included LOG_LEVEL_INF is available.

dcpleung and others added 5 commits January 22, 2024 12:39
This uses arch_cpu_start() instead of arch_start_cpu() as it has
been renamed to align with the CPU namespace.

Signed-off-by: Daniel Leung <[email protected]>
This changes the seconday core power up routine to use the newly
introduced k_smp_cpu_start() and k_smp_cpu_resume(). This removes
the need to mirror part of the SMP start up code from Zephyr, and
no longer need to call into Zephyr private kernel code.

Signed-off-by: Daniel Leung <[email protected]>
nxp_adsp_imx8ulp needs to be in allowed platforms.

Signed-off-by: Anas Nashif <[email protected]>
Use direct call to function instead of going over a redefine.

Signed-off-by: Anas Nashif <[email protected]>
Set min. cmake version required to what zephyr uses.

Signed-off-by: Anas Nashif <[email protected]>
@nordic-krch
Copy link
Author

fyi @lgirdwood
Also I've seen following comment there /* printk supports uint64_t so use it until LOG is ready */. Zephyr logging supports now uint64_t so it maybe worth to consider switching to logging instead of printk.

Header has a guard to not reinclude logging header if it was already
included but inside this guard there is a definition of
SOF_ZEPHYR_TRACE_LEVEL which is later on used. So if log.h is already
earlier included SOF_ZEPHYR_TRACE_LEVEL is not defined and compilation
fails.

Moving this definition outside of the guard because if log.h is already
included LOG_LEVEL_INF is available.

Signed-off-by: Krzysztof Chruściński <[email protected]>
@nordic-krch
Copy link
Author

How can I move it forward? @nashif can you help?

@nordic-krch
Copy link
Author

@nashif @lgirdwood ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants