forked from thesofproject/sof
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: include: sof: trace: Fix the trace level setting #37
Open
nordic-krch
wants to merge
6
commits into
zephyrproject-rtos:zephyr
Choose a base branch
from
nordic-krch:fix_trace_h
base: zephyr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses arch_cpu_start() instead of arch_start_cpu() as it has been renamed to align with the CPU namespace. Signed-off-by: Daniel Leung <[email protected]>
This changes the seconday core power up routine to use the newly introduced k_smp_cpu_start() and k_smp_cpu_resume(). This removes the need to mirror part of the SMP start up code from Zephyr, and no longer need to call into Zephyr private kernel code. Signed-off-by: Daniel Leung <[email protected]>
nxp_adsp_imx8ulp needs to be in allowed platforms. Signed-off-by: Anas Nashif <[email protected]>
Use direct call to function instead of going over a redefine. Signed-off-by: Anas Nashif <[email protected]>
Set min. cmake version required to what zephyr uses. Signed-off-by: Anas Nashif <[email protected]>
fyi @lgirdwood |
Header has a guard to not reinclude logging header if it was already included but inside this guard there is a definition of SOF_ZEPHYR_TRACE_LEVEL which is later on used. So if log.h is already earlier included SOF_ZEPHYR_TRACE_LEVEL is not defined and compilation fails. Moving this definition outside of the guard because if log.h is already included LOG_LEVEL_INF is available. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
fix_trace_h
branch
from
February 1, 2024 06:25
3c057d5
to
bb4f163
Compare
How can I move it forward? @nashif can you help? |
@nashif @lgirdwood ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header has a guard to not reinclude logging header if it was already included but inside this guard there is a definition of SOF_ZEPHYR_TRACE_LEVEL which is later on used. So if log.h is already earlier included SOF_ZEPHYR_TRACE_LEVEL is not defined and compilation fails.
Moving this definition outside of the guard because if log.h is already included LOG_LEVEL_INF is available.