Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements set_interface #169

Merged
merged 1 commit into from
Jan 7, 2025
Merged

implements set_interface #169

merged 1 commit into from
Jan 7, 2025

Conversation

philrhc
Copy link

@philrhc philrhc commented Jan 7, 2025

if selected interface is a single digit, then it is used as an array index in the network interface list
otherwise the selected interface is attempted
otherwise the default behaviour of looping through the network interface list, selecting the first eligible.

this continues the closed pull request here: #164

@philrhc philrhc mentioned this pull request Jan 7, 2025
@sphaero
Copy link
Contributor

sphaero commented Jan 7, 2025

thought of anyway to test this?

@sphaero sphaero merged commit d88864c into zeromq:master Jan 7, 2025
7 checks passed
@philrhc
Copy link
Author

philrhc commented Jan 7, 2025

@sphaero

thought of anyway to test this?

i've only been testing this locally using the chat example app

@philrhc philrhc deleted the set-interface branch January 7, 2025 10:44
@philrhc
Copy link
Author

philrhc commented Jan 7, 2025

i will do some further testing in our application
for automated testing, i am not sure, i think your suggestion is best but it is hard for me to prioritise it:
#164 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants