Added ability to generically convert to &Endpoint without needing ownership of value #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just rebased on top of #76, that should greatly reduce the scope of this PR. I'll rebase again when its merged so its easier to review |
|
I'm going to close this - as we discussed elsewhere, I'm not sure that avoiding a copy of the endpoint is as important for performance as I originally thought - binding and connecting are not in inner loops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #76, suggest reviewing that one first
TryIntoEndpoint has a signature of
try_into(self), which takes ownership overSelf. This is not conducive to situations where we only have a&Endpointor only need a&Endpointreturned, such as inSocket::connect(). This PR addsTryAsRefEndpoint, a failable version ofAsRef<Endpoint>. This allows generically passing either&Endpointor&strvalues to a function, and getting out&Endpoint, without needing to move in the endpoint or perform a clone. This allows functions that would want to take&Endpointand return&Endpointto be generic.In addition, this PR breaks up the endpoints module into submodules for readability, fixes a bug associated with parsing and displayingHosts, and fixes a flaky test.