Bug fixation of ODM\MongoDB\Types\CurrencyType

[olekhy]

• shouldn't use stringtype

[danizord]

@olekhy why? Currency actually implements __toString().

[prolic]

I definitly expect a currency object returned and not a string. Second argument for Money constructor is a Currency instance, not any string is allowed. A currency type returning a string (that is not a currency) is pointless.

[olekhy]

@danizord
because it's make side effekt for.
as f.e.

\Money\Money::__construct($amount, Currency $currency) build a money with a currency instance

after on \Money\Money::getCurrency returned a string

    /**
     * @return \Money\Currency
     */
    public function getCurrency()
    {              var_dump(gettype($this->currency));
        return $this->currency;
    }

when calling in:

class MoneyHydrator implements HydratorInterface
{
    /**
     * {@inheritDoc}
     */
    public function extract($object)
    {                 var_dump(gettype($object->getCurrency())); die;
        return [
            'amount' => $object->getAmount(),
            'currency' => $object->getCurrency()->getName()
        ];
    }

output:

string 'string' (length=6)

string 'string' (length=6)

[olekhy]

👏 wakeup here we needed a worked module... or w'll use my branch for composer installation. ;) temporary.

[fabiocarneiro]

@olekhy Sorry for the delay. Ill review that ASAP.

[olekhy]

@fabiocarneiro Thank you, we will gladly wait for.

[fabiocarneiro]

@olekhy Can you explain the purpose of this method? I'm not familiarized with this conversion.

[olekhy]

@fabiocarneiro http://doctrine-mongodb-odm.readthedocs.org/en/latest/reference/basic-mapping.html#custom-mapping-types

[fabiocarneiro]

As we already discussed in #22. There is no reason to the conversion to be done in the Hydrator and it would also break BC.

If you want to properly display it in you form and it's not working, you should do a Form View Helper instead.

[danizord]

Can you revert this one? We still can inherit convertToDatabaseValue() and closureToMongo() from StringType since Currency implements __toString() method.

[olekhy]

sry no, this is an falsely behavior Currency isn't a string type, BTW doctrine2 and proxy manager (we used) doesn't automatically cast to string. Not useabale with u proposed __toString

[danizord]

Well, in DB side it is a string, so I think it's ok to inherit VO -> string conversions from StringType. Just a suggestion, though. Result still the same :)

[olekhy]

almost all data mapped to string on database side, is more interesting PHP side. because we speak from ODM (ORM) here. Look at times http://doctrine-dbal.readthedocs.org/en/lates/reference/types.html#custom-mapping-types for u should be a float type :). (may better way ObjectType -> serializing of money inclusive currency as one field)

[olekhy]

@danizord @fabiocarneiro i'll close my pr's and hope u implements:

• form element
• CurrencyType included expected improvement.

ok so?

[danizord]

@olekhy Ok, I'll take the Form element (opened #27).

But I'm still not sure about the mongo type (I know nothing about MongoODM). Can you send a separate PR for this one?

[olekhy]

@danizord yeah. Currency type I'll make a separate PR.