Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Milvus 2.5 function feature by bypassing SDK #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huanghaoyuanhhy
Copy link
Collaborator

@huanghaoyuanhhy huanghaoyuanhhy commented Jan 6, 2025

Milvus 2.5 introduced the function feature, which is not well-supported by the older SDK versions. The new SDK hides many internal IDs used by the backup tool. To address this, the backup tool now interacts with Milvus directly via gRPC, bypassing the SDK.

fix: #484

Copy link

mergify bot commented Jan 6, 2025

@huanghaoyuanhhy Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@huanghaoyuanhhy huanghaoyuanhhy changed the title *: directly use grpc to interact with Milvus feat: support Milvus 2.5 function feature by bypassing SDK Jan 6, 2025
@huanghaoyuanhhy huanghaoyuanhhy force-pushed the v5 branch 2 times, most recently from 60e6483 to 7e05b7e Compare January 6, 2025 09:31
@huanghaoyuanhhy huanghaoyuanhhy force-pushed the v5 branch 12 times, most recently from 422a771 to e1e4a81 Compare January 9, 2025 07:46
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huanghaoyuanhhy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Milvus 2.5 introduced the function feature, which is not well-supported by the older SDK versions. The new SDK hides many internal IDs used by the backup tool. To address this, the backup tool now interacts with Milvus directly via gRPC, bypassing the SDK.

Signed-off-by: huanghaoyuanhhy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants