Automatically generate sitemap.xml after building HTMLs #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a sample GH Pages instance to test this? |
|
Not yet, gonna create it now |
refeed
force-pushed
the
sitemap_generator
branch
4 times, most recently
from
0be47df to
732defa
Compare
|
@rht just made one at https://refeed.github.io/zarchive-refeed/ the sitemap is in https://refeed.github.io/zarchive-refeed/sitemap.xml |
|
The sitemap.xml and the .gz looks good. The remaining thing is to add fullstop at the end of your commit messages. |
|
After this PR, it would be a good idea to test the sitemap.xml content when the number of URLS are > 15k. |
refeed
force-pushed
the
sitemap_generator
branch
from
732defa to
073355f
Compare
|
LGTM |
|
Is there any progress on this? This feature would be very useful. |
|
Merged, thanks @refeed! Perhaps you can add documentation of this feature in a follow-up PR? |
|
Sure, will do this weekend! |
|
Just opened a PR for the docs at #92 |
eric-wieser
added a commit
to eric-wieser/zulip-archive
that referenced
this pull request
Jan 15, 2023
This was a typo introduced in zulip#89
eric-wieser
reviewed
Jan 15, 2023
| @@ -32,8 +32,7 @@ python3 get-pip.py | |||
| pip install virtualenv | |||
| virtualenv -p python3 . | |||
| source bin/activate | |||
| pip3 install zulip==0.6.3 | |||
| pip3 install pyyaml==5.2 | |||
| pip3 install install -r requirements.txt | |||
There was a problem hiding this comment.
install is here twice: #96
timabbott
pushed a commit
that referenced
this pull request
Jan 19, 2023
This was a typo introduced in #89.
5twelve
approved these changes
Jun 30, 2024
5twelve
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70