Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't bundle broken zsyncmake #85

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

Samueru-sama
Copy link
Contributor

lets see if we can fix this before this fails

@TheAssassin
Copy link
Member

We do not know for sure that it's broken. As said, if you extract the AppImage, the zsyncmake binary does its job just fine.

@Samueru-sama
Copy link
Contributor Author

Samueru-sama commented Dec 10, 2024

We do not know for sure that it's broken. As said, if you extract the AppImage, the zsyncmake binary does its job just fine.

I'm 100% that's the problem, you can see on Brave AppImage workflow how the zsync files stopped being made after this, and it is a problem that I ran into before when I tried the standalone binary before it was bundled.

Case: #47 (comment)

@TheAssassin
Copy link
Member

Merging for now until we find the bug.

@TheAssassin TheAssassin merged commit 16bb900 into AppImage:main Dec 10, 2024
5 checks passed
@TheAssassin
Copy link
Member

I backed up the broken binaries in https://github.com/AppImage/appimagetool/releases/tag/broken-zsyncmake.

@Samueru-sama
Copy link
Contributor Author

Thanks @TheAssassin but it is too late 😭

image

However it seems this didn't cause the entire Zen workflow to fail like I expected to happen, phew!

@Samueru-sama
Copy link
Contributor Author

Samueru-sama commented Dec 10, 2024

@TheAssassin https://github.com/Samueru-sama/SpeedCrunch-AppImage-test/releases/tag/continuous

Everything went back to normal as expected.

I tested with that other appimage because I forgot that I build rofi on Alpine, so there is no zsync in the runner to test since the alpine repos don't have it, so I did the test with speedcrunch:

Before this PR was merged:

https://github.com/Samueru-sama/SpeedCrunch-AppImage-test/actions/runs/12247983560/job/34166786782

After the PR was merged:

https://github.com/Samueru-sama/SpeedCrunch-AppImage-test/actions/runs/12248171013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants