Make utility buttons available through accessibility actions #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assistive technologies like VoiceOver and Switch Control allow users to perform "actions" on a UI element. To enable that, we implemented an accessibility action for each utility button. The name of the action is the same as the accessibility label of the button. As UIAccessibilityCustomAction class needed for this is available only on iOS 8.0, care has been taken so that it works no matter with which SDK it was compiled and on what iOS version it is run. The underscored methods are underscored so as to make it clear they are not implementations of UIAccessibilityAction protocol methods, but rather internal supporting methods.
This adds convenience accessibility methods that add accessibility labels to the utility buttons created with an image wihtout a title. This is important because buttons with titles automatically get their title as accessibility label, but buttons without a title and with an image nearly always need custom accessibility label, as the default is the image filename stripped of filename suffix. As a matter of fact, whenever one wants to add an image button using an image method of this category, they should always use the accessibility version (except when they already set the correct accessibility label on the UIImage, then it is not strictly necessary). So best would be to deprecate the "old" image methods that do not specify accessibility label. Still, when other accessibility properties (like hint or value) need to be customized (as well as non-accessibility properties), direct access to the button after adding it to the array can be used.
Promote the accessibility methods from our array category in README.md.
Show different means of how accessibility actions for image-only utility buttons get their names: - by using the accessibility variant of the image methods on our NSMutableArray+SWUtilityButtons category - by adding accessibility label directly to the UIImage - by not adding any accessibility label at all (this is not desirable, it just shows the fallback accessibility label derived from the image file name)
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using of utility button actions with VoiceOver and Switch Control.
To test with VoiceOver:
Patches donated by A11Y LTD.