Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drapersniper
force-pushed
the
Improve_shutdowns_reconnects
branch
from
d6eb3f2 to
ce70f28
Compare
Drapersniper
force-pushed
the
Improve_shutdowns_reconnects
branch
from
976e1b4 to
bd847b9
Compare
Drapersniper
force-pushed
the
Improve_shutdowns_reconnects
branch
from
a38c1d7 to
5980294
Compare
Jackenmen
reviewed
Mar 19, 2022
Co-authored-by: jack1142 <[email protected]>
Drapersniper
commented
Mar 20, 2022
aikaterna
approved these changes
Mar 20, 2022
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 20, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 20, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 20, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 20, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 21, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 21, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 28, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Drapersniper
added a commit
to Drapersniper/Red-Lavalink
that referenced
this pull request
Mar 29, 2022
… race conditions (Cog-Creators#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]>
Jackenmen
added a commit
that referenced
this pull request
Mar 29, 2022
* Make port argument in `lavalink.initialize` and `lavalink.node.Node()` * fix, update and improve typehints and documentation in a few place * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions (#117) * Major rework of shutdown and reconnect logs to avoid zombie tasks and race conditions * depends * cleanup nodes * rename vars * missing callbacks * add a `wait_until_ready` to `lavalink` * change order to avoid circular imports * *sigh* * uhh * ensure volume persists on a resume * formatting * revert task callbacks * Apply suggestions from code review Co-authored-by: jack1142 <[email protected]> * Update lavalink/node.py Co-authored-by: jack1142 <[email protected]> * make `Node()` kwarg only * Prevent self.port from being Optional[int] * Update lavalink/lavalink.py Co-authored-by: jack1142 <[email protected]> Co-authored-by: jack1142 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #115
Depends on #118 (For the callback code)Moved the callback code to the logging PR.Depends on #119
Merge Last