fix: exclude_submit_bug #868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggol
approved these changes
Jan 16, 2025
proposals/utils/stepper.py
Outdated
| @@ -262,7 +262,7 @@ def get_form_errors(self, exclude_submit=False): | |||
| # When using this method on the submit page, we | |||
| # use the form's own validation, otherwise it gets | |||
| # validated twice | |||
| if exclude_submit and item.form_class == ProposalSubmitForm: | |||
| if exclude_submit and getattr(item, "form_class", None) == ProposalSubmitForm: | |||
There was a problem hiding this comment.
Test for equal identity of class types should be x is some_class not x == some_class. The latter is for eqaulity of value and is not well-defined for Forms.
We missed both these issues on the first pass, rip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a breaking bug for the new exclude_submit option I added to Stepper.get_form_errors.
If this if statement receives StepperItem's without a form_class attribuge eg. ContainerItem's (used when there are multiple studies), an AttributeError gets raised. This fixes it.